From 2cc66dd5039859c7e75aea69ca69aa49f953980c Mon Sep 17 00:00:00 2001 From: Etienne Samson Date: Thu, 10 Jan 2019 17:03:38 +0100 Subject: [PATCH] cmake: remove unconditional -Wno-deprecated-declaration on APPLE After taking into consideration the following, I think this should be removed : - OpenSSL isn't the default on Apple platforms - you have to jump through hoops to get CMake to use OpenSSL on macOS (headers aren't in `/usr/include`, so you have to provide `-DOPENSSL_*` overrides) - users are likely (as getting anywhere near the installed 0.9.8 version is insanity IMHO) to package a "modern" version, which wouldn't be marked as deprecated --- CMakeLists.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 8dd2992ca..eff2500d5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -235,9 +235,6 @@ ELSE () ENABLE_WARNINGS(int-conversion) DISABLE_WARNINGS(documentation-deprecated-sync) - IF (APPLE) # Apple deprecated OpenSSL - DISABLE_WARNINGS(deprecated-declarations) - ENDIF() IF (PROFILE) SET(CMAKE_C_FLAGS "-pg ${CMAKE_C_FLAGS}")