[midx] Fix an undefined behavior (left-shift signed overflow)

Browse Source

There was a missing check to ensure that the `off64_t` (which is a
signed value) didn't overflow when parsing it from the midx file. This
shouldn't have huge repercusions since the parsed value is immediately
validated afterwards, but then again, there is no such thing as "benign"
undefined behavior.

This change makes all the bitwise arithmetic happen with unsigned types
and is only casted to `off64_t` until the very end.

Thanks to Taotao Gu for finding and reporting this!

...

This commit is contained in:

lhchavez

2022-04-05 13:10:33 -07:00

parent d8015d28a7

commit 33b1d3fd62

2 changed files with 8 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

fuzzers/corpora/midx/666a779eed16847c6930a71c0547a34e52db409e Normal file

Binary file not shown.