Crash after render distance change #23

New Issue

2024-11-03T22:32:03Z

GelbEinhalb commented

2024-11-03 22:32:03 +00:00

(Migrated from github.com)

Description

Ive been experiencing some game crashes when I change the render distance. It seems to mainly happen when I quickly lower it from a high number (like 30) all the way down to 0. It doesnt happen every time, so I cant really figure out whats causing it specifically.

Steps to reproduce

Start the game
Set the render distance to something high, like 30
Wait a bit for some chunks to render (I have only seen it crash when Im a bit further away from spawn and some chunks (above 1500) have already been rendered, but this doesnt have to mean anything)
Suddenly drop it to 0
The game crashes! (MAYBE!?!)

## Description Ive been experiencing some game crashes when I change the render distance. It seems to mainly happen when I quickly lower it from a high number (like 30) all the way down to 0. It doesnt happen every time, so I cant really figure out whats causing it specifically. ## Steps to reproduce 1. Start the game 2. Set the render distance to something high, like 30 3. Wait a bit for some chunks to render _(I have only seen it crash when Im a bit further away from spawn and some chunks (above 1500) have already been rendered, but this doesnt have to mean anything)_ 4. Suddenly drop it to 0 5. The game crashes! (MAYBE!?!)

fintmc commented

2024-11-04 12:19:53 +00:00

(Migrated from github.com)

Can confirm: wait until about 600-1000 chunks are loaded (700 (700 rendered)) and click render distance slider to make it 1-3.

Crash happens at Planet::ChunkThreadUpdate(), most likely at it->first.

Very likely to be caused by thread desync.

Can confirm: wait until about 600-1000 chunks are loaded (`700 (700 rendered)`) and click render distance slider to make it 1-3. Crash happens at `Planet::ChunkThreadUpdate()`, most likely at `it->first`. Very likely to be caused by thread desync.

nowinar commented

2024-11-04 17:19:29 +00:00

(Migrated from github.com)

Hi, I had similar issue, and I made #21 to fix it. Does it resolve that issue for you? Or maybe I am missing something, because that pull request fixes deleting from a map in a loop, not a thread desync. I didn't create issue for that so sorry for the confusion.

GelbEinhalb commented

2024-11-05 08:14:14 +00:00

(Migrated from github.com)

Hi @nowinar
Ill try again later. It could be that your solution already fixed the issue, as I have used the latest build (4 days ago) and not compiled the code myself with your fix (2 days ago)

Hi @nowinar Ill try again later. It could be that your solution already fixed the issue, as I have used the latest build (4 days ago) and not compiled the code myself with your fix (2 days ago)

👍 1

GelbEinhalb commented

2024-11-11 09:36:56 +00:00

(Migrated from github.com)

The issue still seems to occur.
I have built the project on Ubuntu from source and the crashes still happen.

The issue still seems to occur. I have built the project on Ubuntu from source and the crashes still happen.

Sign in to join this conversation.