TheZone/ScuffedMinecraft
1
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases 5 Wiki Activity

Fix cmake #7

Merged
williamistGitHub merged 4 commits from fix-cmake into main 2024-10-18 22:58:58 +00:00
Conversation 3 Commits 4 Files Changed 4 +11 -4
williamistGitHub commented 2024-10-18 21:20:50 +00:00 (Migrated from github.com)
Copy Link

The CMake build errored, and upon fixing that, running it from Visual Studio didn't use the right working directory. This pull request fixes both of those things.

The CMake build errored, and upon fixing that, running it from Visual Studio didn't use the right working directory. This pull request fixes both of those things.
FoxMoss commented 2024-10-18 22:01:34 +00:00 (Migrated from github.com)
Copy Link

This breaks on Linux, the Debian glfw3 package has the binary as just libglfw. Consider creating separate target_link_libraries statements for each OS?

Also I'm now breaking on Planet.h:28

	static const unsigned int chunkSize = 32;

which gives me some cryptic linker error.

This breaks on Linux, the Debian glfw3 package has the binary as just libglfw. Consider creating separate target_link_libraries statements for each OS? Also I'm now breaking on Planet.h:28 ```c++ static const unsigned int chunkSize = 32; ``` which gives me some cryptic linker error.
👍 1
williamistGitHub commented 2024-10-18 22:25:37 +00:00 (Migrated from github.com)
Copy Link

Both of those should be fixed, I was able to compile it on Debian WSL.

Both of those should be fixed, I was able to compile it on Debian WSL.
FoxMoss commented 2024-10-18 22:30:15 +00:00 (Migrated from github.com)
Copy Link

LGTM

LGTM
tsny-houzz (Migrated from github.com) approved these changes 2024-10-18 22:55:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
tsny-houzz
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TheZone/ScuffedMinecraft#7
No description provided.
Delete Branch "fix-cmake"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?