mirror of
https://github.com/libgit2/libgit2.git
synced 2026-06-22 06:26:26 +00:00
remote: do store the update_tips callback error value
We use `git_error_set_after_callback_function` to determine whether `update_tips` returned an error but do not store its return value making us think it always returns 0. Fix it by adding the common patter of storing it inside the `if` when calling it.
This commit is contained in:
@@ -1852,7 +1852,7 @@ static int update_one_tip(
|
||||
}
|
||||
|
||||
if (callbacks && callbacks->update_tips != NULL &&
|
||||
callbacks->update_tips(refname.ptr, &old, &head->oid, callbacks->payload) < 0)
|
||||
(error = callbacks->update_tips(refname.ptr, &old, &head->oid, callbacks->payload)) < 0)
|
||||
git_error_set_after_callback_function(error, "git_remote_fetch");
|
||||
|
||||
done:
|
||||
|
||||
Reference in New Issue
Block a user