Idea-Studios/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-06-22 06:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

blame: don't try to create a blame on error

Browse Source 
When an error occurs... deal with the error, don't try to still create
hunks.
This commit is contained in:
Edward Thomson
2024-07-13 11:06:42 +01:00
parent 1925889139
commit 2cfb83bccc
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/libgit2/blame.c
View File

@@ -432,12 +432,12 @@ static int blame_internal(git_blame *blame)
if ((error = load_blob(blame)) < 0 ||
(error = git_blame__get_origin(&o, blame, blame->final, blame->path)) < 0)
goto cleanup;
goto on_error;
if (git_blob_rawsize(blame->final_blob) > SIZE_MAX) {
git_error_set(GIT_ERROR_NOMEMORY, "blob is too large to blame");
error = -1;
goto cleanup;
goto on_error;
}
blame->final_buf = git_blob_rawcontent(blame->final_blob);
@@ -456,17 +456,19 @@ static int blame_internal(git_blame *blame)
blame->ent = ent;
error = git_blame__like_git(blame, blame->options.flags);
if ((error = git_blame__like_git(blame, blame->options.flags)) < 0)
goto on_error;
cleanup:
for (ent = blame->ent; ent; ) {
git_blame__entry *e = ent->next;
for (ent = blame->ent; ent; ent = ent->next) {
git_blame_hunk *h = hunk_from_entry(ent, blame);
git_vector_insert(&blame->hunks, h);
}
on_error:
for (ent = blame->ent; ent; ) {
git_blame__entry *next = ent->next;
git_blame__free_entry(ent);
ent = e;
ent = next;
}
return error;