Idea-Studios/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-06-22 06:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

regex: make sure to link against PCRE2's regex functions

Browse Source 
PCRE2's header defines just the basic names but that means that we'll link
against libc's version while using PCRE2's struct definitions, leading to
crashes. To work around this, package maintainers have added prefixes to the
exported functions so we can link against them.

But the definitions in the header are still of the basic names so we need to
tell the compiler/linker to replace these names when linking.
This commit is contained in:
Carlos Martín Nieto
2019-09-01 14:59:59 +02:00
parent 5fc27aac6f
commit 5eafc37e95
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/posix_regex.h
View File

@@ -37,8 +37,21 @@
#else
/*
* PCRE2's header defines just the basic names but that means that we'll link
* against libc's version while using PCRE2's struct definitions, leading to
* crashes. To work around this, package maintainers have added prefixes to the
* exported functions so we can link against them.
*
* But the definitions in the header are still of the basic names so we need to
* tell the compiler/linker to replace these names when linking.
*/
# if defined(GIT_REGEX_PCRE2)
# include <pcre2posix.h>
# pragma redefine_extname regerror PCRE2regerror
# pragma redefine_extname regexec PCRE2regexec
# pragma redefine_extname regfree PCRE2regfree
# pragma redefine_extname regcomp PCRE2regcomp
# elif defined(GIT_REGEX_PCRE)
# include <pcreposix.h>
# else