Idea-Studios/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-06-22 06:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7211 from cehoffman/fix-o-fsync-undefined-behavior

Browse Source 
futils: fix undefined behavior in O_FSYNC fallback definition
This commit is contained in:
Edward Thomson
2026-03-24 20:57:58 +00:00
committed by GitHub
parent d78c1eb08f 46208be836
commit 7b33412006
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/util/futils.h
View File

@@ -32,9 +32,17 @@ extern int git_futils_readbuffer_fd(git_str *obj, git_file fd, size_t len);
/* Additional constants for `git_futils_writebuffer`'s `open_flags`. We
* support these internally and they will be removed before the `open` call.
*
* Not all platforms define O_FSYNC. Fall back to O_SYNC (the POSIX
* standard name; O_FSYNC is a non-standard alias) when available,
* otherwise use a sentinel value that won't collide with real open
* flags. Avoid (1 << 31) since left-shifting into the sign bit of
* a signed int is undefined behavior.
*/
#ifndef O_FSYNC
# define O_FSYNC (1 << 31)
#if !defined(O_FSYNC) && defined(O_SYNC)
# define O_FSYNC O_SYNC
#elif !defined(O_FSYNC)
# define O_FSYNC (1 << 30)
#endif
extern int git_futils_writebuffer(