Idea-Studios/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-06-22 06:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

shallow: avoid unnecessary pkt free

Browse Source 
Looks like a double-free here.
This commit is contained in:
Edward Thomson
2023-04-24 11:16:47 +01:00
parent d69c7a7238
commit 8f7fc2ee50
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/libgit2/transports/smart_protocol.c
View File

@@ -408,26 +408,28 @@ int git_smart__negotiate_fetch(git_transport *transport, git_repository *repo, c
goto on_error;
while ((error = recv_pkt((git_pkt **)&pkt, NULL, t, buf)) == 0) {
bool complete = false;
if (pkt->type == GIT_PKT_SHALLOW) {
git_shallowarray_add(wants->shallow_roots, &pkt->oid);
} else if (pkt->type == GIT_PKT_UNSHALLOW) {
git_shallowarray_remove(wants->shallow_roots, &pkt->oid);
} else if (pkt->type == GIT_PKT_FLUSH) {
/* Server is done, stop processing shallow oids */
break;
complete = true;
} else {
git_error_set(GIT_ERROR_NET, "Unexpected pkt type");
goto on_error;
git_error_set(GIT_ERROR_NET, "unexpected packet type");
error = -1;
}
git_pkt_free((git_pkt *) pkt);
if (complete || error < 0)
break;
}
git_pkt_free((git_pkt *) pkt);
if (error < 0) {
if (error < 0)
goto on_error;
}
}
/*
* Our support for ACK extensions is simply to parse them. On