Idea-Studios/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-06-22 06:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(clone): document SHA256 local clone failure

Browse Source 
Local clone, both hardlink and copy paths, does not propagate
the source repository's object format to the destination.

A SHA256 repository cloned locally is initialized as SHA1
and caused object lookup failures.

These tests are added as reproducible examples,
and will be fixed in the next commit

* `sha256_via_no_local`
  * `file://` URL + `GIT_CLONE_NO_LOCAL` -> remote code path
* `sha256_object_format_is_propagated`
  * `file://` URL + `GIT_CLONE_LOCAL` -> local code path with hardlinks
* `sha256_no_links_object_format_is_propagated`
  * `file://` URL + `GIT_CLONE_LOCAL_NO_LINKS` -> local code path with copy
This commit is contained in:
Weihang Lo
2026-04-19 09:31:51 -04:00
parent 1f34e2a57a
commit 9fa192de95
1 changed files with 66 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

66
tests/libgit2/clone/local.c
View File

@@ -266,3 +266,69 @@ void test_clone_local__shallow_fails(void)
cl_git_fail_with(GIT_ENOTSUPPORTED, git_clone(&repo, cl_fixture("testrepo.git"), "./clone.git", &opts));
}
void test_clone_local__sha256_via_no_local(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
cl_skip();
#else
git_repository *repo;
git_clone_options opts = GIT_CLONE_OPTIONS_INIT;
/*
* file:// URL + GIT_CLONE_NO_LOCAL -> remote code path
*
* Should correctly propagate the object format
*/
opts.bare = true;
opts.local = GIT_CLONE_NO_LOCAL;
cl_git_pass(git_clone(&repo, cl_git_fixture_url("testrepo_256.git"), "./clone.git", &opts));
cl_assert_equal_i(GIT_OID_SHA256, git_repository_oid_type(repo));
git_repository_free(repo);
cl_git_pass(git_futils_rmdir_r("./clone.git", NULL, GIT_RMDIR_REMOVE_FILES));
#endif
}
void test_clone_local__sha256_object_format_is_propagated(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
cl_skip();
#else
git_repository *repo;
git_clone_options opts = GIT_CLONE_OPTIONS_INIT;
/*
* file:// URL + GIT_CLONE_LOCAL -> local code path with hardlinks
*
* Should correctly propagate the object format
*/
opts.bare = true;
opts.local = GIT_CLONE_LOCAL;
cl_git_fail(git_clone(&repo, cl_git_fixture_url("testrepo_256.git"), "./clone.git", &opts));
cl_git_pass(git_futils_rmdir_r("./clone.git", NULL, GIT_RMDIR_REMOVE_FILES));
#endif
}
void test_clone_local__sha256_no_links_object_format_is_propagated(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
cl_skip();
#else
git_repository *repo;
git_clone_options opts = GIT_CLONE_OPTIONS_INIT;
/*
* file:// URL + GIT_CLONE_LOCAL_NO_LINKS -> local code path with copy
*
* Should correctly propagate the object format
*/
opts.bare = true;
opts.local = GIT_CLONE_LOCAL_NO_LINKS;
cl_git_fail(git_clone(&repo, cl_git_fixture_url("testrepo_256.git"), "./clone.git", &opts));
cl_git_pass(git_futils_rmdir_r("./clone.git", NULL, GIT_RMDIR_REMOVE_FILES));
#endif
}