Idea-Studios/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-06-22 06:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't reference stack vars in cleanup callback

Browse Source 
If you use the clar cleanup callback function, you can't pass a
reference pointer to a stack allocated variable because when the
cleanup function runs, the stack won't exist anymore.
This commit is contained in:
Russell Belfer
2012-08-01 14:49:47 -07:00
parent 0e26202cd5
commit b769e936d0
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests-clar/core/mkdir.c
View File

@@ -102,8 +102,11 @@ void test_core_mkdir__with_base(void)
static void cleanup_chmod_root(void *ref)
{
mode_t *mode = ref;
if (*mode != 0)
if (*mode != 0) {
(void)p_umask(*mode);
git__free(mode);
}
git_futils_rmdir_r("r", GIT_DIRREMOVAL_EMPTY_HIERARCHY);
}
@@ -111,12 +114,12 @@ static void cleanup_chmod_root(void *ref)
void test_core_mkdir__chmods(void)
{
struct stat st;
mode_t old = 0;
mode_t *old = git__malloc(sizeof(mode_t));
*old = p_umask(022);
cl_set_cleanup(cleanup_chmod_root, &old);
cl_set_cleanup(cleanup_chmod_root, old);
cl_git_pass(git_futils_mkdir("r", NULL, 0777, 0));
old = p_umask(022);
cl_git_pass(git_futils_mkdir("mode/is/important", "r", 0777, GIT_MKDIR_PATH));