Idea-Studios/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-06-22 06:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7226 from weihanglo/local-object-format

Browse Source 
fix(clone): propagate object format in local clone
This commit is contained in:
Edward Thomson
2026-04-23 22:11:06 +01:00
committed by GitHub
parent 08d91d0fbf 87c03c1aaa
commit d35f378794
2 changed files with 75 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libgit2/clone.c
View File

@@ -519,6 +519,12 @@ static int clone_local_into(
return error;
}
/* Propagate the source repository's object format to the target
* so that it can read the copied object database. */
if ((error = git_repository__set_objectformat(
repo, git_repository_oid_type(src))) < 0)
goto cleanup;
if (git_repository__item_path(&src_odb, src, GIT_REPOSITORY_ITEM_OBJECTS) < 0 ||
git_repository__item_path(&dst_odb, repo, GIT_REPOSITORY_ITEM_OBJECTS) < 0) {
error = -1;

69
tests/libgit2/clone/local.c
View File

@@ -266,3 +266,72 @@ void test_clone_local__shallow_fails(void)
cl_git_fail_with(GIT_ENOTSUPPORTED, git_clone(&repo, cl_fixture("testrepo.git"), "./clone.git", &opts));
}
void test_clone_local__sha256_via_no_local(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
cl_skip();
#else
git_repository *repo;
git_clone_options opts = GIT_CLONE_OPTIONS_INIT;
/*
* file:// URL + GIT_CLONE_NO_LOCAL -> remote code path
* Should correctly propagate the object format
*/
opts.bare = true;
opts.local = GIT_CLONE_NO_LOCAL;
cl_git_pass(git_clone(&repo, cl_git_fixture_url("testrepo_256.git"), "./clone.git", &opts));
cl_assert_equal_i(GIT_OID_SHA256, git_repository_oid_type(repo));
git_repository_free(repo);
cl_git_pass(git_futils_rmdir_r("./clone.git", NULL, GIT_RMDIR_REMOVE_FILES));
#endif
}
void test_clone_local__sha256_object_format_is_propagated(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
cl_skip();
#else
git_repository *repo;
git_clone_options opts = GIT_CLONE_OPTIONS_INIT;
/*
* file:// URL + GIT_CLONE_LOCAL -> local code path with hardlinks
* Should correctly propagate the object format
*/
opts.bare = true;
opts.local = GIT_CLONE_LOCAL;
cl_git_pass(git_clone(&repo, cl_git_fixture_url("testrepo_256.git"), "./clone.git", &opts));
cl_assert_equal_i(GIT_OID_SHA256, git_repository_oid_type(repo));
git_repository_free(repo);
cl_git_pass(git_futils_rmdir_r("./clone.git", NULL, GIT_RMDIR_REMOVE_FILES));
#endif
}
void test_clone_local__sha256_no_links_object_format_is_propagated(void)
{
#ifndef GIT_EXPERIMENTAL_SHA256
cl_skip();
#else
git_repository *repo;
git_clone_options opts = GIT_CLONE_OPTIONS_INIT;
/*
* file:// URL + GIT_CLONE_LOCAL_NO_LINKS -> local code path with copy
* Should correctly propagate the object format
*/
opts.bare = true;
opts.local = GIT_CLONE_LOCAL_NO_LINKS;
cl_git_pass(git_clone(&repo, cl_git_fixture_url("testrepo_256.git"), "./clone.git", &opts));
cl_assert_equal_i(GIT_OID_SHA256, git_repository_oid_type(repo));
git_repository_free(repo);
cl_git_pass(git_futils_rmdir_r("./clone.git", NULL, GIT_RMDIR_REMOVE_FILES));
#endif
}