Idea-Studios/libgit2
2
0
Fork 0
mirror of https://github.com/libgit2/libgit2.git synced 2026-06-22 06:26:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source
This commit is contained in:
Edward Thomson
2022-07-12 22:09:25 -04:00
committed by GitHub
parent 760a5acc73
commit f6be8c2697
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libgit2/branch.c
View File

@@ -53,7 +53,7 @@ static int not_a_local_branch(const char *reference_name)
return -1;
}
static bool branch_name_follows_pattern(const char *branch_name)
static bool branch_name_is_valid(const char *branch_name)
{
/*
* Discourage branch name starting with dash,
@@ -84,7 +84,7 @@ static int create_branch(
GIT_ASSERT_ARG(ref_out);
GIT_ASSERT_ARG(git_commit_owner(commit) == repository);
if (!branch_name_follows_pattern(branch_name)) {
if (!branch_name_is_valid(branch_name)) {
git_error_set(GIT_ERROR_REFERENCE, "'%s' is not a valid branch name", branch_name);
error = -1;
goto cleanup;
@@ -808,7 +808,7 @@ int git_branch_name_is_valid(int *valid, const char *name)
*valid = 0;
if (!name || !branch_name_follows_pattern(name))
if (!name || !branch_name_is_valid(name))
goto done;
if ((error = git_str_puts(&ref_name, GIT_REFS_HEADS_DIR)) < 0 ||

6
src/libgit2/tag.c
View File

@@ -244,7 +244,7 @@ on_error:
return -1;
}
static bool tag_name_follows_pattern(const char *tag_name)
static bool tag_name_is_valid(const char *tag_name)
{
/*
* Discourage tag name starting with dash,
@@ -278,7 +278,7 @@ static int git_tag_create__internal(
return -1;
}
if (!tag_name_follows_pattern(tag_name)) {
if (!tag_name_is_valid(tag_name)) {
git_error_set(GIT_ERROR_TAG, "'%s' is not a valid tag name", tag_name);
return -1;
}
@@ -554,7 +554,7 @@ int git_tag_name_is_valid(int *valid, const char *name)
GIT_ASSERT(valid);
if (!name || !tag_name_follows_pattern(name))
if (!name || !tag_name_is_valid(name))
goto done;
if ((error = git_str_puts(&ref_name, GIT_REFS_TAGS_DIR)) < 0 ||