TheZone/ScuffedMinecraft
1
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases 5 Wiki Activity

feat: allow cmake built executable to be run anywhere #10

Merged
FoxMoss merged 2 commits from main into main 2024-10-20 14:52:23 +00:00
Conversation 2 Commits 2 Files Changed 2 +46 -4
FoxMoss commented 2024-10-19 18:24:33 +00:00 (Migrated from github.com)
Copy Link

Provides reasonable results to situations like #9

Provides reasonable results to situations like #9
👍 2
fintmc commented 2024-10-19 18:40:36 +00:00 (Migrated from github.com)
Copy Link

LGTM

LGTM
fintmc commented 2024-10-19 18:45:27 +00:00 (Migrated from github.com)
Copy Link

could be a good idea to add a check if the 'assets' folder is present in the directory as well to be 100% sure this is correct, otherwise print/display an error prompting to check if the binary is placed in the correct place

could be a good idea to add a check if the 'assets' folder is present in the directory as well to be 100% sure this is correct, otherwise print/display an error prompting to check if the binary is placed in the correct place
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TheZone/ScuffedMinecraft#10
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?