TheZone/ScuffedMinecraft
1
0
Fork 0
Code Issues 7 Pull Requests 4 Actions Packages Projects Releases 5 Wiki Activity

Fixing crash when changing render distance #21

Open
nowinar wants to merge 1 commits from nowinar/fix-for-changing-render-distance into main
pull from: nowinar/fix-for-changing-render-distance
merge into: TheZone:main
Conversation 1 Commits 1 Files Changed 1 +4 -2
nowinar commented 2024-11-02 21:30:09 +00:00 (Migrated from github.com)
Copy Link

This fixes a bug in Planet.cpp which caused crash when lowering the render distance.
As of my observations, it is fixed by this commit.
It was caused by deleting from a map which we were iterating through.
The crash is shown in this screenshot:
image
And this is the call stack:

ScuffedMinecraft.exe!std::_List_const_iterator<std::_List_val<std::_List_simple_types<std::pair<ChunkPos const ,ChunkData *>>>>::operator++() Line 160 C++
ScuffedMinecraft.exe!std::_List_iterator<std::_List_val<std::_List_simple_types<std::pair<ChunkPos const ,ChunkData *>>>>::operator++() Line 246 C++
ScuffedMinecraft.exe!Planet::ChunkThreadUpdate() Line 108 C++

This fixes a bug in Planet.cpp which caused crash when lowering the render distance. As of my observations, it is fixed by this commit. It was caused by deleting from a map which we were iterating through. The crash is shown in this screenshot: ![image](https://github.com/user-attachments/assets/357a9e21-6427-4ff8-b5e8-41b63d0294d2) And this is the call stack: > ScuffedMinecraft.exe!std::_List_const_iterator<std::_List_val<std::_List_simple_types<std::pair<ChunkPos const ,ChunkData *>>>>::operator++() Line 160 C++ > ScuffedMinecraft.exe!std::_List_iterator<std::_List_val<std::_List_simple_types<std::pair<ChunkPos const ,ChunkData *>>>>::operator++() Line 246 C++ > ScuffedMinecraft.exe!Planet::ChunkThreadUpdate() Line 108 C++
fintmc commented 2024-11-05 16:14:44 +00:00 (Migrated from github.com)
Copy Link

LGTM

LGTM
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin nowinar/fix-for-changing-render-distance:nowinar/fix-for-changing-render-distance
git checkout nowinar/fix-for-changing-render-distance
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TheZone/ScuffedMinecraft#21
No description provided.
Delete Branch "nowinar/fix-for-changing-render-distance"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?