Merge af3d63ad0f into 1204ac400b

[Compilers] Fix implicit typecast in simd hash function
[Core] Fix implicit simd typecast on arm architectures
2025-04-22 14:18:35 +00:00 · 2025-03-28 19:12:05 +07:00 · 2025-03-28 11:52:20 +13:00 · 2025-03-28 11:47:57 +13:00 · 2025-03-27 10:14:17 +13:00
1 changed files with 4 additions and 4 deletions
--- a/clay.h
+++ b/clay.h
@ -136,7 +136,7 @@ static inline void Clay__SuppressUnusedLatchDefinitionVariableWarning(void) { (v
    for (                                                                                                                                                   \
        CLAY__ELEMENT_DEFINITION_LATCH = (Clay__OpenElement(), Clay__ConfigureOpenElement(CLAY__CONFIG_WRAPPER(Clay_ElementDeclaration, __VA_ARGS__)), 0);  \
        CLAY__ELEMENT_DEFINITION_LATCH < 1;                                                                                                                 \
-        ++CLAY__ELEMENT_DEFINITION_LATCH, Clay__CloseElement()                                                                                              \
+        CLAY__ELEMENT_DEFINITION_LATCH=1, Clay__CloseElement()                                                                                              \
    )

 // These macros exist to allow the CLAY() macro to be called both with an inline struct definition, such as
@ -1376,7 +1376,7 @@ uint64_t Clay__HashData(const uint8_t* data, size_t length) {
            length -= 16;
        }
        else {
-            for (int i = 0; i < length; i++) {
+            for (size_t i = 0; i < length; i++) {
                overflowBuffer[i] = data[i];
            }
            msg = _mm_loadu_si128((const __m128i*)overflowBuffer);
@ -1433,11 +1433,11 @@ uint64_t Clay__HashData(const uint8_t* data, size_t length) {
            length -= 8;
        }
        else {
-            for (int i = 0; i < length; i++) {
+            for (size_t i = 0; i < length; i++) {
                overflowBuffer[i] = data[i];
            }
            uint8x8_t lower = vld1_u8(overflowBuffer);
-            msg = vcombine_u8(lower, vdup_n_u8(0));
+            msg = vreinterpretq_u64_u8(vcombine_u8(lower, vdup_n_u8(0)));
            length = 0;
        }
        v0 = veorq_u64(v0, msg);
Author	SHA1	Message	Date
Joram Vandemoortele	479a30f146	Merge `af3d63ad0f` into `1204ac400b`	2025-03-28 19:12:05 +07:00
Nic Barker	1204ac400b	[Compilers] Fix implicit typecast in simd hash function Some checks failed CMake on multiple platforms / build (Release, cl, cl, windows-latest) (push) Has been cancelled Details CMake on multiple platforms / build (Release, clang, clang++, ubuntu-latest) (push) Has been cancelled Details CMake on multiple platforms / build (Release, gcc, g++, ubuntu-latest) (push) Has been cancelled Details	2025-03-28 11:52:20 +13:00
Nic Barker	6a7ce77024	[Core] Fix implicit simd typecast on arm architectures	2025-03-28 11:47:57 +13:00
Piggybank Studios	7c9506bc31	[Core] Fix CLAY__ELEMENT_DEFINITION_LATCH overflow in CLAY macro if 256 loops end at the same time Some checks are pending CMake on multiple platforms / build (Release, cl, cl, windows-latest) (push) Waiting to run Details CMake on multiple platforms / build (Release, clang, clang++, ubuntu-latest) (push) Waiting to run Details CMake on multiple platforms / build (Release, gcc, g++, ubuntu-latest) (push) Waiting to run Details	2025-03-27 10:14:17 +13:00